Skip to content

Qualcomm AI Engine Direct - op enablement #7786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jan 22, 2025
Merged

Qualcomm AI Engine Direct - op enablement #7786

facebook-github-bot merged 1 commit into from
Jan 22, 2025

Conversation

@haowhsu-quic
Copy link
Collaborator

@haowhsu-quic haowhsu-quic commented Jan 21, 2025 •
edited by pytorch-bot bot
Loading

Summary

  • abs, arange, eq, full_like, eq, ge, gt, log, le, lt, min, max, repeat
  • test cases & bug fixes
  • support Snapdragon 8 Elite

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperators -s $DEVICE_SERIAL -m SM8650 -b build-android/

cc @cccclai @winskuo-quic @shewu-quic

@haowhsu-quic
Qualcomm AI Engine Direct - op enablement
5156b44 
summary
- abs, arange, eq, full_like, eq, ge, gt, log, le, lt, min, max, repeat
- test cases & bug fixes
- support Snapdragon 8 Elite
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7786

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5156b44 with merge base e00eaea (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@haowhsu-quic
Copy link
Collaborator Author

haowhsu-quic commented Jan 21, 2025

Hi @cccclai, this PR enables most of the ops mentioned in last week. For torch.stft, we might need to have a separated PR for QNN has no complex datatype support.
QC AIHUB has enabled few different Whisper variants. What they did is taking mel sectrogram as one of its inputs, which is pre-calculated in CPU side (https://github.com/quic/ai-hub-models/blob/7b48eebdbe35611a5232cd46ab0931d6c24d4544/qai_hub_models/models/_shared/whisper/app.py#L369).

Thank you.

cccclai
cccclai approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding all the ops support!

@cccclai cccclai added release notes: qualcomm Changes to the Qualcomm backend delegate partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm topic: not user facing labels Jan 21, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 21, 2025

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@winskuo-quic winskuo-quic mentioned this pull request Jan 22, 2025
Closed
@facebook-github-bot facebook-github-bot merged commit 07113ec into pytorch:main Jan 22, 2025
45 of 50 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@haowhsu-quic @YIWENX14
Qualcomm AI Engine Direct - op enablement
7a4ea4b 
Differential Revision: D68453829

Pull Request resolved: #7786
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@haowhsu-quic
Qualcomm AI Engine Direct - op enablement
f79697a 
Differential Revision: D68453829

Pull Request resolved: pytorch#7786
@haowhsu-quic haowhsu-quic deleted the dev_op_support branch February 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

+1 more reviewer

@tarun292 tarun292 tarun292 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm release notes: qualcomm Changes to the Qualcomm backend delegate topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haowhsu-quic @facebook-github-bot @cccclai @tarun292